Standardize actors colors #773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 1d in the function
Clarkszw
changed the title
skoudoro
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Hi @Clarkszw,
Thank you for starting this.
See below for some comments:
-
Concerning docstring, I recommend you looking at the numpy style guide. Many python projects follow those rule which you are not following right now on this PR. here the link:
https://numpydoc.readthedocs.io/en/latest/format.html -
Why red? I recommend you to normalize your color values to go from [0-255] to [0-1]
|
also, can you solve the conflict in this PR ? thank you |
|
I have no idea why it will happen..But the conflict has been fixed now:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new function
check_color_range()It does two things:
change it to red color [1, 0, 0] and print the out of bounds informationnormalize the color array.I have written an unit test for this function and added in test_utils.py
All tests in test_actors.py and test_utils.py are passed :)